Linter improvements #117
Merged
Linter improvements #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0nstantx
approved these changes
Mar 14, 2022
| @@ -163,7 +163,7 @@ func (s *Seeder) Seed(cfg *config.Config) error { | |||
| // the parsing won't stop, and we make sure we try to parse every flag passed when running the command. | |||
| for _, arg := range os.Args[1:] { | |||
| if err := flagSet.Parse([]string{arg}); err != nil { | |||
| // Simply log errors that can happen, such as parsing unexpected flags. We want this to be silent | |||
| // Simply log errors that can happen, such as parsing unexpected flags. We want this to be silent, | |||
There was a problem hiding this comment.
Very naive comment, but would it be better to move the comment after the period (.) to the next line ?
There was a problem hiding this comment.
There is no guideline for that. Personally I am optimizing for vertical space and only go to the next line if the content does not fit the width. More can be displayed this way, l;less scrolling.
Lazaros-Tsigkakos
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Linter improvements.
Short description of the changes